Conversation
Finishing from a subdirectory inside an agent worktree made the active-worktree check compare the source worktree root against the physical subdirectory. That let cleanup remove the caller's cwd after a successful merge, which then surfaced as a false background-command failure. Constraint: Preserve active shell cwd even if this leaves the detached worktree for a later gx cleanup pass. Rejected: Always pivot prune to the primary checkout | it can delete the caller's active shell cwd and recreate the false failure. Confidence: high Scope-risk: narrow Directive: Active-cwd cleanup must compare worktree roots, not raw pwd values. Tested: node --test test/finish.test.js; node --test --test-name-pattern 'agent-branch-finish pivots' test/metadata.test.js; bash -n scripts/agent-branch-finish.sh; bash -n templates/scripts/agent-branch-finish.sh; git diff --check; openspec validate --specs Not-tested: Live Claude background shell prompt refresh after finish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).